support new TCPConnector param fingerprint#366
Conversation
docs/client.rst
Outdated
There was a problem hiding this comment.
Please replace '...' with example of arbitrary fingerprint. It may help to newcomers very well.
05f059c to
4214961
Compare
|
@asvetlov Thanks, implemented all your suggestions. Please let me know if latest patch looks better. Just wasn't sure what you wanted here. Yes, the property returns a string (or None if not set). Happy to rename this (something like expected_fingerprint?) everywhere rather than verify_fingerprint if you prefer? |
e93fabc to
df23fce
Compare
verify_fingerprintexpect_fingerprint
|
pushed a new version with |
df23fce to
17008ed
Compare
aiohttp/connector.py
Outdated
There was a problem hiding this comment.
Should we have a way to pass bytes fingerprint?
There was a problem hiding this comment.
Should we have a way to pass bytes fingerprint?
Something like 8661202?
ddfc5ef to
8661202
Compare
aiohttp/connector.py
Outdated
There was a problem hiding this comment.
Sorry for bad guess, req.ssl may clash with ProxyConnector.
Please use transport.get_extra_info('sslcontext') instead as flag that transport.get_extra_info('socket') has certificate info.
|
Sorry for long review, I'm striving to make code perfect. After looking on the last version I incline to accept We need also for Library users can find the helper function easy if you mention it in Clean separation to byte-ish fingerprint for usage in connector and helper for converting user-readable
Both We are in the middle on getting rid of sphinx autodoc generated documentation (docstrings in If you are too boring in writing documentation please left it to me -- I'll accept your PR after code and tests done but very appreciate your help in documentation also. |
8661202 to
7041757
Compare
expect_fingerprintfingerprint
6a8e019 to
0e1219a
Compare
enables ssl certificate pinning
0e1219a to
173ef3f
Compare
Fixes #350