support new param 'response_class' in websocket_client.ws_connect.

[davebshow]

Adds a 'response_class' parameter to websocket_client.ws_connect that allows user to implement a custom ClientWebSocketResponse style class and pass it to the ws_connect coroutine. Similar to 'response_class' param for aiohttp.client.request.

[asvetlov]

Please use

if response_class is None:
    response_class = ClientWebSocketResponse idiom

[asvetlov]

The patch is LGTM (except my inline note).
I think we should add websockets (and maybe multiparts) to ClientSession also.

[davebshow]

Thanks asvetlov! I updated the patch to reflect your inline note.

[davebshow]

Couple more small changes for consistency in the docs. I'm done now with this feature.

[asvetlov]

Thanks!

[davebshow]

Thank you for reviewing @asvetlov Quick question: when you said earlier "I think we should add websockets (and maybe multiparts) to ClientSession also", were you referring to using the ClientSession to issue the handshake request and in this way establishing multiple websocket connections using the same ClientSession? If so, I was already implementing something like this in a project using aiohttp components. It would be easy to submit a patch. Maybe I'm off though and you were thinking of something a bit more hardcore.

[asvetlov]

I think we need ClientSession.connect_ws() coroutine, method parameters may be subject of discussion.

[asvetlov]

@davebshow if you would make PR for that -- please do. It will be at least nice starting point.

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.