fix request content-length header erasing after post redirect#391
Merged
asvetlov merged 2 commits intoaio-libs:masterfrom Jun 6, 2015
Merged
fix request content-length header erasing after post redirect#391asvetlov merged 2 commits intoaio-libs:masterfrom
asvetlov merged 2 commits intoaio-libs:masterfrom
Conversation
Member
|
The change looks good but please add a test also. |
asvetlov
added a commit
that referenced
this pull request
Jun 6, 2015
fix request content-length header erasing after post redirect
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When performing a POST request with some data to server and it answers with redirect 303 See other with location of resource.
So when we are trying to handle redirect to that resource, we still have a Content-Length header left from POST. It cause
send_headersmethod to try to write payload with no data but with lengthMaybe this fix just fixing the symptom, but what I want is to pay attention at POST with data redirect problem