Skip to content

multiple file upload with same key#433

Merged
asvetlov merged 3 commits intoaio-libs:masterfrom
pankajnits:master
Jul 7, 2015
Merged

multiple file upload with same key#433
asvetlov merged 3 commits intoaio-libs:masterfrom
pankajnits:master

Conversation

@pankajnits
Copy link
Contributor

if multiple files are uploaded with same key , only last file descriptor is open and rest is closed

@asvetlov
Copy link
Member

asvetlov commented Jul 7, 2015

At least add a test please.

@pankajnits
Copy link
Contributor Author

sure will add do you want me to modiy test_client_request.py or should i add different test file

@asvetlov
Copy link
Member

asvetlov commented Jul 7, 2015

@pankajnits I suggest adding new test to test_web_functional.py

@pankajnits
Copy link
Contributor Author

thanks added test case for this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use self.assertFalse

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like check for file content for example.
Say, on first cycle iteration it should be b'binary data 1' and for second pass b'binary data 2'

@pankajnits
Copy link
Contributor Author

thanks will incorporate this change

asvetlov added a commit that referenced this pull request Jul 7, 2015
multiple file upload with same key
@asvetlov asvetlov merged commit 4b5ea25 into aio-libs:master Jul 7, 2015
@asvetlov
Copy link
Member

asvetlov commented Jul 7, 2015

Thanks!

@lock
Copy link

lock bot commented Oct 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants