Avoid putting a new connection in the free list#471
Closed
mpaolini wants to merge 1 commit intoaio-libs:masterfrom
Closed
Avoid putting a new connection in the free list#471mpaolini wants to merge 1 commit intoaio-libs:masterfrom
mpaolini wants to merge 1 commit intoaio-libs:masterfrom
Conversation
The invariant should be: a transport is either in the free list (_conns) or in the active list (_acquired). This fixes a bug that put every newly created connection in both lists
Contributor
Author
|
basically I am reverting the changes made in #406 ... but the tests still pass |
Merged
Contributor
Author
|
superseded by #473 . Maybe this can be closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The invariant should be: a transport is either in the free list (_conns)
or in the active list (_acquired).
This fixes a bug that put every newly created connection in both lists