Conversation
…nto alexsdutton-signals-v2
aiohttp/signals.py
Outdated
There was a problem hiding this comment.
Is it possible to ensure that all the receivers in Signal are callable? Otherwise it won't be cool to get some TypeError: 'int' object is not callable from the deepest aiohttp internals without any pointers about what the signal that was and where it came from.
There was a problem hiding this comment.
Initial version from @alexsdutton had signature check. But I quite unhappy with it.
I prefer adding good checker later but keeping no checks at all in first implementation.
|
Also I have strong feeling we need two special signals for every signal call: first before the call and second after signal processing finished. Those debug signals are extremely useful for tools like
So The current PR is final from my perspective, I'll push it into master if no objections will appear until Friday. After that I'd like to publish next 0.18 release |
Conflicts: tests/conftest.py
@alexsdutton I've decided to drop signature check at all, at least for now.