Websocket XOR performance improved. Fixes #686

[socketpair]

Both cython and pure python-based.

[kxepal]

sys.byteorder is little (at least for me), while iirc websocket uses network one which is big. Could anyone confirm this?

[socketpair]

in that operation, byte order is irrelevant, since actual numeric value is not used in that code. i.e. byte representation of xored result does not depend on that order.

But, it is a question, which order is optimal to internal bigint logic in python.

[kxepal]

Ah, ok. Thanks!

[asvetlov]

Please report about performance improvement.
I want to mention it in release notes.

[socketpair]

@asvetlov

Please report about performance improvement.
In which form ?

I has changed pure-python and cython code. seems both should be faster.

P.S. Also, thaere are no tests that tests xor correctness

[socketpair]

@asvetlov I cannot measure performance increase correctly. It varies from 1.2 to 40 for both Python and Cython implementations....

[asvetlov]

@socketpair Ok.
Thanks.

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.