Added ServiceRestart and TryAgainLater websocket close codes#828
Merged
asvetlov merged 2 commits intoaio-libs:masterfrom Mar 15, 2016
Merged
Added ServiceRestart and TryAgainLater websocket close codes#828asvetlov merged 2 commits intoaio-libs:masterfrom
asvetlov merged 2 commits intoaio-libs:masterfrom
Conversation
These codes are listed in IANA registry: https://www.iana.org/assignments/websocket/websocket.xml#table-close-code-number But without this change `aiohttp` doesn't allow to use them.
Member
|
Please add tests |
Contributor
Author
|
Not sure where should I put that testing. Placed it in |
asvetlov
added a commit
that referenced
this pull request
Mar 15, 2016
Added ServiceRestart and TryAgainLater websocket close codes
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What these changes does?
Allows using IANA standard websocket close codes
1012 Service Restartand1013 Try Again LaterHow to test your changes?
Expected behaviour: websocket closed with 1012 code
Actual behaviour without this PR:
Related issue number
None
Checklist
These codes are listed in IANA registry: https://www.iana.org/assignments/websocket/websocket.xml#table-close-code-number
But without this change
aiohttpdoesn't allow to use them.