Fix #976: Add support for websocket send_json and receive_json

[vitaliemaldur]

What do these changes do?

Add support for websocket server to send json and for websocket client to send and receive json

Are there changes in behavior for the user?

User can use methods:
send_json and receive_json both on websocket server and client

Related issue number

#976

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes

[coveralls]

Coverage decreased (-0.2%) to 97.803% when pulling 7fb73d0 on vitaliemaldur:master into 328bb36 on KeepSafe:master.

[asvetlov]

Please call .send_str() instead of working on low level.

[asvetlov]

Would you add tests also?

[vitaliemaldur]

Yes I will

[coveralls]

Coverage decreased (-0.1%) to 97.864% when pulling 611a286 on vitaliemaldur:master into 328bb36 on KeepSafe:master.

[vitaliemaldur]

@asvetlov what I can do to avoid

AttributeError: 'module' object has no attribute 'JSONDecodeError'
tests\test_web_websocket.py:161: AttributeError

I am using json.decoder.JSONDecodeError in a try/except.

Also, do you have some suggestions for the tests I wrote?

[asvetlov]

These checks are not required: .send_str() performs them anyway.
There is no need to do the check twice.

[vitaliemaldur]

@asvetlov I've noticed that in web_ws.py we have send_str, send_bytes, send_json methods and coresponding receive_str, receive_bytes, receive_json. But in websocket_client.py we have send_str, send_bytes, send_json methods and only receive_json. Is that on purpose? or should I add the rest of methods there?

[asvetlov]

I think yes.
From my perspective we should support the same methods for both client and server for consistency.

[coveralls]

Coverage decreased (-0.04%) to 97.945% when pulling 66c2c00 on vitaliemaldur:master into 328bb36 on KeepSafe:master.

[coveralls]

Coverage decreased (-0.04%) to 97.945% when pulling 524669e on vitaliemaldur:master into 328bb36 on KeepSafe:master.

[coveralls]

Coverage decreased (-0.008%) to 97.974% when pulling 8fd4aa9 on vitaliemaldur:master into 328bb36 on KeepSafe:master.

[vitaliemaldur]

@asvetlov I have added all the methods discussed above, now we have:

• send_str
• send_bytes
• send_json
• receive_str
• receive_bytes
• receive_json

both on websocket_client.py and web_ws.py. I have also added documentation for them.

[asvetlov]

Thanks!

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.