Refine OR null masking for search function

[airborne12]

Summary

• analyze OR clauses to detect NOT operators and shared fields so we only skip NULL masking when every branch is independent
• adjust NULL bitmap collection to avoid unnecessary unions when masking is not required while preserving the existing behavior otherwise
• extend function_search_test with scenarios that compare search against match_any/match_all row sets for OR across fields and OR with NOT on the same field

Testing

• not run (not requested)

---

https://chatgpt.com/codex/tasks/task_e_68da65558fe483268789ba22921fd836

---

Note

Analyze OR clauses for null-safety to decide when to mask/collect NULLs, and add targeted tests to validate behavior.

• Search null handling:
  • Add analyze_null_safety to detect NOT and cross-field overlaps; introduce is_or_clause_null_safe.
  • Update should_mask_null_values to mask only unsafe OR trees; preserve masking for others.
  • Refactor NULL bitmap collection via collect_query_null_bitmap_internal(..., collect_nulls) to avoid reading/unioning NULL bitmaps when not needed; handle has_null() as Result<bool>.
• API/Headers:
  • Add helpers and declarations in function_search.h; include <unordered_set>/<vector>.
• Tests:
  • Add TrackingIndexIterator and new cases:
    • OR across different fields: no NULL masking/collection.
    • OR with NOT on same field: apply NULL masking and collect NULLs.
  • Extend assertions for has-null checks and bitmap effects.

^{Written by Cursor Bugbot for commit 67aa9bd. This will update automatically on new commits. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch codex/extend-should_mask_null_values-function

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}