Feat: Enable logging when new stream starts#288
Conversation
WalkthroughWalkthroughThe main changes are in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant BaseSource
participant Logger
User->>BaseSource: Call _execute(args)
BaseSource->>BaseSource: Start executing stream
BaseSource->>Logger: Log stream read start event (_log_stream_read_start)
Logger-->>BaseSource: Event logged
BaseSource-->>User: Yield AirbyteMessages
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
/fix-pr
|
|
/test-pr
|
|
CodeRabbit (@coderabbitai) review |
Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
CodeRabbit (@coderabbitai) review |
Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- airbyte/sources/base.py (3 hunks)
Additional comments not posted (3)
airbyte/sources/base.py (3)
78-78: LGTM!The addition of the
_last_stream_processedattribute is a good approach to track the last processed stream.
627-629: LGTM!The
_log_stream_read_startmethod correctly logs the commencement of reading a stream.
586-588: LGTM!The integration of
_last_stream_processedand the call to_log_stream_read_startwithin the_executemethod is correct.
|
/test-pr
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- airbyte/sources/base.py (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- airbyte/sources/base.py
|
Looks like an unrelated CI test failure: |
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- airbyte/sources/base.py (3 hunks)
- tests/unit_tests/test_lowcode_connectors.py (1 hunks)
Files skipped from review due to trivial changes (1)
- tests/unit_tests/test_lowcode_connectors.py
Additional comments not posted (2)
airbyte/sources/base.py (2)
78-78: LGTM!The attribute
_stream_names_observedis correctly initialized as an empty set to track unique stream names.
627-629: LGTM!The method
_log_stream_read_startcorrectly logs the start of stream reading events with the current time.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
/test-pr
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- airbyte/sources/base.py (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- airbyte/sources/base.py
Aaron ("AJ") Steers (aaronsteers)
left a comment
Aaron ("AJ") Steers (aaronsteers)
left a comment
There was a problem hiding this comment.
Tests are passing and it looks like this is ready to go!
Thanks, vspanxcode (@vspanxcode) for this contribution! 🙌
|
vspanxcode (@vspanxcode) can you please contact me on Airbyte Slack or email marcos (at) airbyte.io |
3 participants
Related to : #229
New Outcome when we read from source
Summary by CodeRabbit