chore: add python 3.12 support#596
Conversation
📝 WalkthroughWalkthroughThe pull request introduces Python 3.12 to the existing GitHub Actions workflow for pytest testing, expanding the testing matrix to include the latest Python version. Additionally, the Changes
Possibly related PRs
Suggested reviewers
Is there anything specific you would like to explore further about these changes? 😊 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (7)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/python_pytest.yml (1)
Line range hint
31-195: I noticed different Poetry versions across jobs - wdyt about aligning them?
- pytest-fast uses Poetry 2.0.1
- Other jobs use Poetry 1.7.1
Would you like to standardize on Poetry 2.0.1 across all jobs since it's the newer version? This could help maintain consistency. 🤔
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/python_pytest.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: Pytest (All, Python 3.11, Windows)
- GitHub Check: Pytest (All, Python 3.11, Ubuntu)
- GitHub Check: Pytest (No Creds)
- GitHub Check: Pytest (All, Python 3.10, Windows)
- GitHub Check: Pytest (All, Python 3.10, Ubuntu)
- GitHub Check: Pytest (Fast)
🔇 Additional comments (1)
.github/workflows/python_pytest.yml (1)
136-136: LGTM on adding Python 3.12! Just a quick verification needed.Let's make sure our dependencies are compatible with Python 3.12. Would you like me to help verify this? 🤔
✅ Verification successful
Looking good for Python 3.12! Just a small heads-up about airbyte-cdk 🔍
Most of our critical dependencies (pandas, SQLAlchemy, Snowflake, BigQuery) explicitly support Python 3.12. While airbyte-cdk doesn't advertise explicit support yet, our version constraints in pyproject.toml look safe. Would you like to test the airbyte-cdk integration specifically with Python 3.12 during the rollout? 🤔
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check package compatibility with Python 3.12 # Get package dependencies from pyproject.toml echo "Checking pyproject.toml dependencies..." cat pyproject.toml | grep -A 50 "^\[tool.poetry.dependencies\]" # Check if any dependencies have known Python 3.12 compatibility issues echo "Checking PyPI for Python 3.12 classifiers..." while IFS= read -r package; do if [[ $package =~ ^[a-zA-Z0-9-]+= ]]; then pkg_name=$(echo "$package" | cut -d'=' -f1) curl -s "https://pypi.org/pypi/${pkg_name}/json" | \ jq -r '.info.classifiers[] | select(contains("Programming Language :: Python :: 3.12"))' fi done < <(cat pyproject.toml | grep -A 50 "^\[tool.poetry.dependencies\]")Length of output: 1886
Script:
#!/bin/bash # Check Python 3.12 compatibility for critical dependencies echo "Checking critical dependencies..." PACKAGES=( "airbyte-cdk" "duckdb" "pandas" "sqlalchemy" "snowflake-connector-python" "google-cloud-bigquery" ) for pkg in "${PACKAGES[@]}"; do echo "=== Checking $pkg ===" curl -s "https://pypi.org/pypi/${pkg}/json" | \ jq -r --arg pkg "$pkg" ' if (.info.classifiers | any(contains("Programming Language :: Python :: 3.12"))) then "\($pkg): ✓ Supports Python 3.12" else "\($pkg): ⚠️ No explicit Python 3.12 support found" end' doneLength of output: 2861
|
/fix-pr
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
airbyte/logs.py(3 hunks)airbyte/progress.py(5 hunks)
🧰 Additional context used
🪛 Ruff (0.8.2)
airbyte/logs.py
18-18: time.strptime imported but unused
Remove unused import: time.strptime
(F401)
26-26: airbyte_cdk.utils.datetime_helpers.ab_datetime_format imported but unused
Remove unused import: airbyte_cdk.utils.datetime_helpers.ab_datetime_format
(F401)
🪛 GitHub Actions: Run Linters
airbyte/logs.py
[error] 12-29: Import block is un-sorted or un-formatted
[error] 18-18: Unused import: time.strptime
[error] 26-26: Unused import: airbyte_cdk.utils.datetime_helpers.ab_datetime_format
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Pytest (All, Python 3.12, Windows)
- GitHub Check: Pytest (All, Python 3.12, Ubuntu)
- GitHub Check: Pytest (No Creds)
- GitHub Check: Pytest (All, Python 3.11, Windows)
- GitHub Check: Pytest (All, Python 3.11, Ubuntu)
- GitHub Check: Pytest (All, Python 3.10, Windows)
- GitHub Check: Pytest (Fast)
- GitHub Check: Pytest (All, Python 3.10, Ubuntu)
🔇 Additional comments (3)
airbyte/logs.py (2)
65-65: LGTM! Clear stack level handling.The explicit setting of
stacklevel=0whenwith_stackisFalseimproves code clarity.
Line range hint
413-414: LGTM! Consistent datetime handling.The changes consistently replace pendulum with
ab_datetime_now().strftime()for timestamp formatting, aligning with the PR objective to add Python 3.12 support by removing the pendulum dependency.Also applies to: 427-427, 433-434, 540-541, 558-559
🧰 Tools
🪛 Ruff (0.8.2)
18-18:
time.strptimeimported but unusedRemove unused import:
time.strptime(F401)
26-26:
airbyte_cdk.utils.datetime_helpers.ab_datetime_formatimported but unusedRemove unused import:
airbyte_cdk.utils.datetime_helpers.ab_datetime_format(F401)
🪛 GitHub Actions: Run Linters
[error] 18-18: Unused import:
time.strptime
[error] 26-26: Unused import:
airbyte_cdk.utils.datetime_helpers.ab_datetime_formatairbyte/progress.py (1)
35-35: LGTM! Clean import addition.The addition of
ab_datetime_nowimport aligns with the changes to remove pendulum dependency.
Aaron ("AJ") Steers (aaronsteers)
marked this pull request as ready for review
|
/poetry-lock
|
Aaron ("AJ") Steers (aaronsteers)
deleted the
aj/chore/add-py312-support
branch
1 participant
Summary by CodeRabbit
airbyte-cdkdependency version from^6.9.0to^6.28.0pendulumdependency