ci: add "not flaky" condition to on-demand test workflow#678
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the on-demand test workflow to exclude flaky tests by modifying the marker filter in the pytest command.
- Updated the marker filter from "not super_slow" to "not super_slow and not flaky" to exclude flaky tests.
- No other changes were introduced in this file.
📝 WalkthroughWalkthroughThe GitHub Actions workflow was updated to exclude both "super_slow" and "flaky" tests from the pytest run during pull request checks. A clarifying comment was also added to explain the rationale for these exclusions. No changes were made to the workflow's control flow or environment. Changes
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/test-pr-command.yml (2)
91-92: Align comment terminology with marker namingThe comment uses “super-slow” (with a hyphen) while the pytest marker is
super_slow(with an underscore), which could confuse readers. Could we update the comment to “super_slow” to match the marker name, wdyt?
96-96: Simplify and clarify the pytest marker expressionThe current
-m "not super_slow and not flaky"works, but would-m 'not (super_slow or flaky)'or even removing the quotes in favor of single quotes improve readability and avoid any YAML quoting pitfalls? What do you think, wdyt?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/test-pr-command.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Pytest (All, Python 3.10, Ubuntu)
- GitHub Check: Pytest (All, Python 3.10, Windows)
- GitHub Check: Pytest (All, Python 3.11, Ubuntu)
- GitHub Check: Pytest (All, Python 3.11, Windows)
Important
Auto-merge enabled.
This PR is set to merge automatically when all requirements are met.
Summary by CodeRabbit
Note
Auto-merge may have been disabled. Please check the PR status to confirm.