Skip to content

ci: add "not flaky" condition to on-demand test workflow#678

Merged
Aaron ("AJ") Steers (aaronsteers) merged 2 commits into
mainfrom
aj/ci/skip-flaky-tests-in-on-demand-workflow
May 26, 2025
Merged

ci: add "not flaky" condition to on-demand test workflow#678
Aaron ("AJ") Steers (aaronsteers) merged 2 commits into
mainfrom
aj/ci/skip-flaky-tests-in-on-demand-workflow

Conversation

@aaronsteers

@aaronsteers Aaron ("AJ") Steers (aaronsteers) commented May 26, 2025

Copy link
Copy Markdown
Member

Important

Auto-merge enabled.

This PR is set to merge automatically when all requirements are met.

Summary by CodeRabbit

  • Chores
    • Updated automated test workflow to exclude both "super_slow" and "flaky" tests during pull request runs, improving speed and reliability of test results.

Note

Auto-merge may have been disabled. Please check the PR status to confirm.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the on-demand test workflow to exclude flaky tests by modifying the marker filter in the pytest command.

  • Updated the marker filter from "not super_slow" to "not super_slow and not flaky" to exclude flaky tests.
  • No other changes were introduced in this file.

Comment thread .github/workflows/test-pr-command.yml
@coderabbitai

coderabbitai Bot commented May 26, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The GitHub Actions workflow was updated to exclude both "super_slow" and "flaky" tests from the pytest run during pull request checks. A clarifying comment was also added to explain the rationale for these exclusions. No changes were made to the workflow's control flow or environment.

Changes

File(s) Change Summary
.github/workflows/test-pr-command.yml Updated pytest marker expression to exclude "flaky" tests; added comment explaining the exclusions.

Possibly related PRs


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/test-pr-command.yml (2)

91-92: Align comment terminology with marker naming

The comment uses “super-slow” (with a hyphen) while the pytest marker is super_slow (with an underscore), which could confuse readers. Could we update the comment to “super_slow” to match the marker name, wdyt?


96-96: Simplify and clarify the pytest marker expression

The current -m "not super_slow and not flaky" works, but would -m 'not (super_slow or flaky)' or even removing the quotes in favor of single quotes improve readability and avoid any YAML quoting pitfalls? What do you think, wdyt?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6cb8e07 and 0fa1bd0.

📒 Files selected for processing (1)
  • .github/workflows/test-pr-command.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Pytest (All, Python 3.10, Ubuntu)
  • GitHub Check: Pytest (All, Python 3.10, Windows)
  • GitHub Check: Pytest (All, Python 3.11, Ubuntu)
  • GitHub Check: Pytest (All, Python 3.11, Windows)

@aaronsteers Aaron ("AJ") Steers (aaronsteers) merged commit 5a593f9 into main May 26, 2025
21 checks passed
@aaronsteers Aaron ("AJ") Steers (aaronsteers) deleted the aj/ci/skip-flaky-tests-in-on-demand-workflow branch May 26, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants