feat: Set AIRBYTE_CLOUD_MCP_SAFE_MODE default to 1#845
Conversation
- Changed default from 0 to 1 in _tool_utils.py - Updated MCP documentation examples to show SAFE_MODE=1 - Updated documentation to reflect new defaults - Safe mode now enabled by default to prevent accidental destructive operations Co-Authored-By: AJ Steers <aj@airbyte.io>
Original prompt from AJ Steers |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/safe-mode-default-1' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/safe-mode-default-1'Helpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
Community SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
📝 WalkthroughWalkthroughFlip default MCP safe-mode to enabled and update inline documentation: SAFE_MODE now defaults to "1" (enabled) unless explicitly set to "0"; READONLY_MODE remains default "0". Corresponding docs in the MCP package were rewritten to describe Safe Mode and Read-Only Mode behavior and env var usage. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
🔇 Additional comments (2)
Comment |
- Created new 'Environment Variables for Cloud Operations' L4 section - Moved SAFE_MODE and READ_ONLY documentation from bullets to dedicated section - Improved formatting and discoverability of safety configuration options Co-Authored-By: AJ Steers <aj@airbyte.io>
- Fixed 'allowd' -> 'allowed' - Fixed 'configuratioins' -> 'configurations' - Fixed 'conssidered' -> 'considered' - Added missing 'to' in 'to enable' - Fixed line length issues for linting Co-Authored-By: AJ Steers <aj@airbyte.io>
Devin Session: https://app.devin.ai/sessions/11bea17b89694183953ebc1b341d2940
Summary by CodeRabbit
Chores
Documentation