Skip to content

Do not merge: experiment — enable sharedNestedComponentsJan2026 to test Schemas-pattern name recovery #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aaron ("AJ") Steers (aaronsteers) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not merge: experiment — enable sharedNestedComponentsJan2026 to test Schemas-pattern name recovery #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ generation:
requestResponseComponentNamesFeb2024: false
securityFeb2025: false
sharedErrorComponentsApr2025: false
sharedNestedComponentsJan2026: false
sharedNestedComponentsJan2026: true

@devin-ai-integration devin-ai-integration Bot Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Enabling sharedNestedComponentsJan2026 will change generated SDK output

Toggling sharedNestedComponentsJan2026 from false to true at gen.yaml:15 will alter the Speakeasy code generation output the next time the SDK is regenerated. This flag likely changes how nested components are shared/deduplicated in the generated models. The PR only changes the config — it does not include the corresponding regenerated SDK code. This is expected per the repo's workflow (config changes are committed first, then /generate is run on the PR or regeneration is triggered via CI), but the reviewer should ensure regeneration is triggered before merge so the generated code under src/airbyte_api/ reflects this flag change and passes the zero-diff drift check.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@devin-ai-integration devin-ai-integration Bot Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Not fixing. This is an experiment/research PR (note the "Do not merge" title). Generation was already triggered and completed — the result showed zero impact on generated code. The zero-diff check failure is expected since this PR intentionally changes gen config. Keeping open per maintainer request as evidence of what this flag does.

@devin-ai-integration devin-ai-integration Bot Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Not fixing. Same as above — this is a "Do not merge" research PR. Generation was already triggered and completed; the flag produced zero diff in generated code. The drift failure is expected and intentional.

nameOverrideFeb2026: false
auth:
oAuth2ClientCredentialsEnabled: true
Expand Down
Loading