Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge: experiment — overlay rename RowFilteringOperationNot to fix model_rebuild bug #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Do not merge: experiment — overlay rename RowFilteringOperationNot to fix model_rebuild bug #184
Changes from all commits
bb4c893816ae8eeb4a0a3b54f2d9File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Old rowfilteringoperationnot_1.py file not deleted — dead code left behind
The old file
src/airbyte_api/models/rowfilteringoperationnot_1.pystill exists on disk but is no longer imported or referenced by anything in the codebase. The__init__.pyno longer mapsRowFilteringOperationNot1in its lazy loading dict or__all__list. The file is harmless dead code, but it could confuse contributors. Its companion docdocs/models/rowfilteringoperationnot1.mdalso remains. This likely happened because Speakeasy's generation step adds/modifies files but doesn't automatically remove files from a previous generation run. Consider deleting both stale files, or adding a cleanup step to the generation pipeline.Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☑️ Resolved in PR #187. Removed both stale files (
rowfilteringoperationnot_1.pyandrowfilteringoperationnot1.md). Confirmed zero references toRowFilteringOperationNot1in the codebase.Uh oh!
There was an error while loading. Please reload this page.