Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1560,7 +1560,12 @@ def create_exponential_backoff_strategy(
)

def create_http_requester(
self, model: HttpRequesterModel, decoder: Decoder, config: Config, *, name: str
self,
model: HttpRequesterModel,
config: Config,
decoder: Decoder = JsonDecoder(parameters={}),
Comment thread
aldogonzalez8 marked this conversation as resolved.
*,
name: str,
) -> HttpRequester:
authenticator = (
self._create_component_from_model(
Expand Down Expand Up @@ -1976,9 +1981,9 @@ def create_record_selector(
config: Config,
*,
name: str,
transformations: List[RecordTransformation],
decoder: Optional[Decoder] = None,
client_side_incremental_sync: Optional[Dict[str, Any]] = None,
transformations: List[RecordTransformation] | None = None,
decoder: Decoder | None = None,
Comment thread
aldogonzalez8 marked this conversation as resolved.
client_side_incremental_sync: Dict[str, Any] | None = None,
**kwargs: Any,
) -> RecordSelector:
assert model.schema_normalization is not None # for mypy
Expand Down Expand Up @@ -2008,7 +2013,7 @@ def create_record_selector(
name=name,
config=config,
record_filter=record_filter,
transformations=transformations,
transformations=transformations or [],
Comment thread
aldogonzalez8 marked this conversation as resolved.
schema_normalization=schema_normalization,
parameters=model.parameters or {},
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2634,6 +2634,42 @@ def test_create_custom_schema_loader():
assert isinstance(component, MyCustomSchemaLoader)


class MyCustomRetriever(SimpleRetriever):
pass


def test_create_custom_retriever():
stream_model = {
"type": "DeclarativeStream",
"retriever": {
"type": "CustomRetriever",
"class_name": "unit_tests.sources.declarative.parsers.test_model_to_component_factory.MyCustomRetriever",
"record_selector": {
"type": "RecordSelector",
"extractor": {
"type": "DpathExtractor",
"field_path": [],
},
"$parameters": {"name": ""},
},
"requester": {
"type": "HttpRequester",
"name": "list",
"url_base": "orange.com",
"path": "/v1/api",
"$parameters": {"name": ""},
},
},
}

stream = factory.create_component(
model_type=DeclarativeStreamModel, component_definition=stream_model, config=input_config
)

assert isinstance(stream, DeclarativeStream)
assert isinstance(stream.retriever, MyCustomRetriever)


@freezegun.freeze_time("2021-01-01 00:00:00")
@pytest.mark.parametrize(
"config, manifest, expected",
Expand Down