Skip to content

chore: move ruff configuration to dedicated ruff.toml file#237

Merged
Aaron ("AJ") Steers (aaronsteers) merged 3 commits into
mainfrom
devin/1737497851-move-ruff-config
Jan 21, 2025
Merged

chore: move ruff configuration to dedicated ruff.toml file#237
Aaron ("AJ") Steers (aaronsteers) merged 3 commits into
mainfrom
devin/1737497851-move-ruff-config

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot commented Jan 21, 2025

Description

This PR moves the Ruff configuration from pyproject.toml to a dedicated ruff.toml file at the root of the repository. This change follows the common practice of keeping Ruff configuration in its own file for better visibility and maintainability.

Closes #238

Changes

  • Created new ruff.toml with existing Ruff configuration
  • Removed Ruff configuration from pyproject.toml
  • Updated CONTRIBUTING.md to reference the new configuration location
  • Verified that Ruff commands continue to work as expected

Testing

  • ✅ Verified that ruff check . runs successfully
  • ✅ Verified that ruff format --check . runs successfully
  • ✅ All existing Ruff functionality remains intact

Link to Devin run: https://app.devin.ai/sessions/89cf98f8fbc74663aa2a8690acf34215

devin-ai-integration Bot and others added 3 commits January 21, 2025 22:17
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration Bot changed the title refactor: move ruff configuration to dedicated ruff.toml file chore: move ruff configuration to dedicated ruff.toml file Jan 21, 2025
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 👍

@aaronsteers Aaron ("AJ") Steers (aaronsteers) deleted the devin/1737497851-move-ruff-config branch January 21, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move projects' ruff rules out of pyproject.toml files and into their own ruff.toml files

1 participant