Skip to content

fix: don't mypy unit_tests#241

Merged
Natik Gadzhi (natikgadzhi) merged 2 commits into
mainfrom
ng/mypy-unit-tests
Jan 23, 2025
Merged

fix: don't mypy unit_tests#241
Natik Gadzhi (natikgadzhi) merged 2 commits into
mainfrom
ng/mypy-unit-tests

Conversation

@natikgadzhi
Copy link
Copy Markdown
Contributor

@natikgadzhi Natik Gadzhi (natikgadzhi) commented Jan 22, 2025

Bad, temporary fix to avoid the editor becoming a full clown fiesta.

Is there a path to have a relaxed set of rules for unit_tests and actually enforce them? It feels bad to drop mypy from editors in tests completely.

Summary by CodeRabbit

  • Configuration
    • Updated type checking configuration to exclude unit test directory from mypy type checking.

…ests, let's not do mypy for unit tests. Which is bad, but.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 22, 2025

📝 Walkthrough

Walkthrough

The pull request introduces a configuration change in the mypy.ini file to exclude the unit_tests/ directory from mypy type checking. This modification allows type checking to skip the specified directory, potentially reducing noise or focusing type analysis on the main codebase.

Changes

File Change Summary
mypy.ini Added exclude = unit_tests/ under [mypy] section to exclude unit tests directory from type checking

The change is straightforward and focused on type checking configuration. Would you like me to elaborate on any aspect of this modification? 🤔


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1494458 and 89242d7.

📒 Files selected for processing (1)
  • mypy.ini (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • mypy.ini
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Pytest (Fast)
  • GitHub Check: Analyze (python)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aaronsteers
Copy link
Copy Markdown
Member

Is there a path to have a relaxed set of rules for unit_tests and actually enforce them? It feels bad to drop mypy from editors in tests completely.

Yes, I think we can have relaxed rules in specific subdirectories. I know this is possible with Ruff and 92% confident we can do it in mypy also.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natikgadzhi Natik Gadzhi (natikgadzhi) deleted the ng/mypy-unit-tests branch January 23, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants