chore: simplify RequestOption construction in component factory#303
Merged
Christo Grabowski (ChristoGrab) merged 6 commits intoJan 31, 2025
Conversation
Christo Grabowski (ChristoGrab)
requested a review
from Maxime Carbonneau-Leclerc (maxi297)
Christo Grabowski (ChristoGrab)
changed the title
Maxime Carbonneau-Leclerc (maxi297)
approved these changes
Jan 31, 2025
Contributor
Maxime Carbonneau-Leclerc (maxi297)
left a comment
Maxime Carbonneau-Leclerc (maxi297)
left a comment
There was a problem hiding this comment.
LGTM! Just a small nit
| ) | ||
| assert stream_slicer.end_time_option.inject_into == RequestOptionType.body_json | ||
| assert stream_slicer.end_time_option.field_name.eval({}) == "before_created_at" | ||
| assert stream_slicer.end_time_option.field_path[0].eval({}) == "before_created_at" |
Contributor
There was a problem hiding this comment.
nit: The outcome could be that stream_slicer.end_time_option.field_path == ["before_created_at", "another dummy parameter that we don't expect"]. Should we change this to assert stream_slicer.end_time_option.field_path == ["before_created_at"]`?
Collaborator
Author
There was a problem hiding this comment.
Agreed, updated the test assertion
Christo Grabowski (ChristoGrab)
merged commit 24264a0
into
christo/request-option-field-path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Refactor components in the model_to_component factory that build child RequestOptions to leverage the re-usable
_create_component_from_modelmethod, rather than instantiating them with explicit attributes (ie,field_name). Hopefully this will reduce future tech debt if the RequestOption class is further modified moving forward.Updates a couple tests to verify the behavior when using nested body_json injected values.