feat: add CsvDecoder to support streaming CSV parsing#321
feat: add CsvDecoder to support streaming CSV parsing#321devin-ai-integration[bot] wants to merge 3 commits into
Conversation
🤖 Devin AI EngineerOriginal prompt from natik@airbyte.io: I'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
| type: | ||
| type: string | ||
| enum: [XmlDecoder] | ||
| CsvDecoder: |
There was a problem hiding this comment.
This looks good, but you also need to add CsvDecoder as an option to all the spots in the schema that accept XmlDecoder as an option.
|
CodeRabbit (@coderabbitai) review please? |
|
Aaron ("AJ") Steers (@aaronsteers) I'm not sure why CI checks don't seem to be in progress — anything I am missing? Do they want some form of human approval? |
🧩 Analysis chain🏁 Script executed: Length of output: 81135 🏁 Script executed: Length of output: 2393 🏁 Script executed: Length of output: 11993 🏁 Script executed: Length of output: 1303 Natik Gadzhi (@natikgadzhi) I've reviewed the PR. The implementation looks good with proper error handling and configurable options. Here's my feedback:
Would you like me to help with any of these suggestions? The code is ready to be used as is, but adding more tests would improve reliability. (`・ω・´)ゞ ✅ Actions performedReview triggered.
|
|
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Natik Gadzhi (@natikgadzhi) - It seems recently GitHub introduced what seems like (indefensible, IMHO) behavior of not starting tests in there are conflicts. I think if you resolve those, tests should run again. |
Co-Authored-By: natik@airbyte.io <natik@airbyte.io>
Co-Authored-By: natik@airbyte.io <natik@airbyte.io>
a6bd700 to
e1907ff
Compare
|
/format-fix |
|
/autofix
|
|
This has been superseded with Maxime Carbonneau-Leclerc (@maxi297)'s PR! |
Pull request was closed
|
This PR specifically: #326 |
Add CsvDecoder to support streaming CSV parsing with configurable delimiter and encoding.
Link to Devin run: https://app.devin.ai/sessions/452c02a6b9e449ab863d5ad2747cc7b1
Requested by: natik@airbyte.io