chore: reorder inject_into in RequestOption and fix title and description in refresh token updater#635
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reorders the inject_into property in the RequestOption schema to appear above field_name, making the UI presentation more intuitive. It also removes a duplicate inject_into block elsewhere in the definitions.
- Moved the
inject_intoblock to be directly abovefield_namein theRequestOptiondefinition. - Removed a redundant
inject_intoentry further down in the schema.
Comments suppressed due to low confidence (2)
airbyte_cdk/sources/declarative/declarative_component_schema.yaml:3421
- [nitpick] Consider adding a
defaultvalue forinject_intoto maintain backward compatibility for consumers who don’t explicitly set it.
inject_into:
airbyte_cdk/sources/declarative/declarative_component_schema.yaml:3434
- Since UI behavior depends on this ordering, consider adding or updating a test to verify that
inject_intonow appears beforefield_namein the generated schema.
field_name:
📝 WalkthroughWalkthroughThe schema for the Changes
Would you like me to help draft a quick note for the changelog or PR description to highlight these clarifications and tidy-ups? Wdyt? 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
PyTest Results (Full)3 696 tests 3 685 ✅ 18m 9s ⏱️ Results for commit 54b6bff. ♻️ This comment has been updated with latest results. |
|
Aldo Gonzalez (@aldogonzalez8) could you give this a quick look when you have a sec? |
Aldo Gonzalez (aldogonzalez8)
left a comment
There was a problem hiding this comment.
APPROVED
just left an annoying question behind. Non blocker.
5873c39 to
54b6bff
Compare
Inject Into should be above field name/path, as this makes more conceptual sense in the UI.
I also changed some of the titles, descriptions, and default values in refresh_token_updater to better match what the user should expect in the UI
Summary by CodeRabbit