Closed
Conversation
According to the API documentation array parameters must be encoded like this:
'&image_size[]=3&image_size[]=4'
akirahrkw
added a commit
that referenced
this pull request
Dec 29, 2013
Owner
|
@cykl sorry for late reply. yes, there was the bug, but actually in order to make oauth request normally, I also need to modify other parts(oauth_signature etc). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the API documentation array parameters must be encoded like this:
'&image_size[]=3&image_size[]=4'
The fix seems to work fine and to not introduce regression. But I have not ran the test suite nor implemented a test case.