added ellipses to getMethylationStats - #1
Closed
bbarrilleaux wants to merge 1 commit into
Closed
Conversation
Owner
|
this is great! thanks for fix. Could you make the changes to the "development" branch not to the master branch? and It would be great if you can:
I'm not terribly experienced with github but the reason I want to use the development branch for development is to make sure we only release a working version in the master branch after I do R CMD CHECK and make sure everything is working as intended. I will collect the changes made in the "development" branch after a while and test, and bump up the version and replace the master branch with the development. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using methylKit 0.9.2, Rstudio 0.98.484, and R 3.0.2. Currently, if I try to override the default number of breaks for the histogram generated by getMethylationStats, it fails to pass the breaks argument on to the hist() function call that generates the labels.
For example, if I try:
the images come out with incorrect labels because it's generating 10 labels instead of 5 or 20:
I fixed the problem by adding ellipses to the label-generating hist() function call.