Skip to content
This repository was archived by the owner on Oct 15, 2025. It is now read-only.

Added vscode plugin as submodule#132

Closed
mparati31 wants to merge 1 commit intoalbertlauncher:masterfrom
mparati31:master
Closed

Added vscode plugin as submodule#132
mparati31 wants to merge 1 commit intoalbertlauncher:masterfrom
mparati31:master

Conversation

@mparati31
Copy link
Copy Markdown
Contributor

No description provided.

@Sharsie
Copy link
Copy Markdown
Contributor

Sharsie commented Dec 27, 2022

@mparati31 Would you consider adding the support for vscode extension Project Manager? I'm no python wizzard, so I'd be in favor of your vscode plugin over mine, though I make a heavy use of the PM extension myself.
The code I wrote for it is here: https://github.com/Sharsie/albertlauncher-vscode-projects/blob/main/__init__.py#L143-L191

I would also welcome accent normalization on the query and recents/PM results, so stuff like È can be searched with e

If you like, I can eventually PR these changes on top of your repository, although I don't come from the python world.

@mparati31
Copy link
Copy Markdown
Contributor Author

@Sharsie Good idea, I'll be adding support for the PM extension and accent normalization in the next few days.

@ManuelSchneid3r
Copy link
Copy Markdown
Member

Actually because reviewing is such a pain using submodules I'd recommend to not use them. 0.18 is out. please check the new api https://github.com/albertlauncher/plugins/blob/master/python/README.md

@ManuelSchneid3r
Copy link
Copy Markdown
Member

@mparati31 do you still plan to get this merged?

@ManuelSchneid3r
Copy link
Copy Markdown
Member

Closing due to conflicts. Please join the discussoin at #114.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

3 participants