This repository was archived by the owner on Mar 11, 2026. It is now read-only.
Merged
Conversation
GregoryElliott
force-pushed
the
gelliott/sdk_naming
branch
from
431d782 to
e54aa30
Compare
vahnag
reviewed
Apr 11, 2025
| ...(rawWebhook.app_id !== undefined && { appId: rawWebhook.app_id }) | ||
| ...(rawWebhook.app_id !== undefined && { appId: rawWebhook.app_id }), | ||
| // Only include the name in the final response if it's defined | ||
| ...(rawWebhook.name !== undefined && { name: rawWebhook.name }) |
Contributor
There was a problem hiding this comment.
You might not need this extra check as all webhook types can have a name.
Contributor
Author
There was a problem hiding this comment.
hmm - name is a nullable field - seems like a good idea to keep the check? we did the same thing for app_id which is also nullable
| */ | ||
| network?: Network; | ||
| /** Optional name for the webhook. */ | ||
| name?: string; |
Contributor
There was a problem hiding this comment.
How do you feel about defining a base CommonWebhookParams with name property that all of these interfaces would extend?
Contributor
Author
There was a problem hiding this comment.
i like that - updated
vahnag
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add name as an option to the create-webhook api SDK - the name parameter already exists on the create-webhook alchemy api
ASANA TASK: https://app.asana.com/1/1129441638109975/project/1208969177908953/task/1209648386732973?focus=true