Skip to content

Pause monitoring#77

Merged
alexbrazier merged 3 commits into
alexbrazier:masterfrom
Vooban:pause
May 23, 2023
Merged

Pause monitoring#77
alexbrazier merged 3 commits into
alexbrazier:masterfrom
Vooban:pause

Conversation

@jwallet

@jwallet jwallet commented May 18, 2023

Copy link
Copy Markdown
Contributor
  • to enable more options I removed the alert "show more"
  • added option to "pause" the network monitoring and "resume" it.

@alexbrazier

Copy link
Copy Markdown
Owner

I like the pause option, but is it not still possible to use the Alert for it? At some point I was thinking of cleaning it up to look more like this so there could be more options next to the search bar and maybe eventually switching to an ActionSheet or Modal.

image

This option seems to limit us to 3 options like the Alert on Android as any more would cause it to go onto more lines
image

@jwallet

jwallet commented May 20, 2023

Copy link
Copy Markdown
Contributor Author

You are totally right
Alert is limited to 3 options. My option is limited by the device width. The dot button is the way to go with a popover menu options.

@jwallet

jwallet commented May 21, 2023

Copy link
Copy Markdown
Contributor Author

options moved to a modal

@alexbrazier alexbrazier left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but seems there are some merge conflicts to resolve

@alexbrazier alexbrazier merged commit 11d4494 into alexbrazier:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants