Skip to content

'Resume' needs to apply missed logs#89

Merged
alexbrazier merged 16 commits into
alexbrazier:masterfrom
Vooban:resume-apply-missed-logs
Sep 24, 2024
Merged

'Resume' needs to apply missed logs#89
alexbrazier merged 16 commits into
alexbrazier:masterfrom
Vooban:resume-apply-missed-logs

Conversation

@jwallet

@jwallet jwallet commented Dec 18, 2023

Copy link
Copy Markdown
Contributor

needs : MR #88

using pause/resume, if we resume, all missed logs are ignored. we changed that so if we resume, the logger will get updated with all missed logs.

maybe it will be better to have:

  • watch/unwatch (record/stop) (e.g.: record in browser network tab)
  • freeze/unfreeze (pause/resume)

changes:

  • changed the example to send random requests (easier to see which ones were part of pausedRequests)
  • keep an array of requests while the logger is paused and apply all missed logs to the queue when resumed

@jwallet jwallet force-pushed the resume-apply-missed-logs branch from 81599ad to 3142089 Compare December 18, 2023 22:37
@jwallet jwallet changed the title Resume apply missed logs Resume' apply missed logs Dec 19, 2023
@jwallet jwallet changed the title Resume' apply missed logs 'Resume' needs to apply missed logs Dec 19, 2023
@jwallet jwallet changed the title 'Resume' needs to apply missed logs 'Resume' needs to apply missing logs Dec 19, 2023
@jwallet jwallet changed the title 'Resume' needs to apply missing logs 'Resume' needs to apply missed logs Dec 21, 2023
@jwallet jwallet force-pushed the resume-apply-missed-logs branch from 726ae59 to b88afea Compare December 21, 2023 13:27
Comment thread src/Logger.ts
@jwallet jwallet marked this pull request as draft April 23, 2024 16:40
@jwallet jwallet marked this pull request as ready for review June 3, 2024 20:17
@alexbrazier alexbrazier merged commit 0ecd3e8 into alexbrazier:master Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants