Skip to content

Format schema sql#803

Merged
tolikzinovyev merged 2 commits intodevelopfrom
tolik/format-schema
Dec 2, 2021
Merged

Format schema sql#803
tolikzinovyev merged 2 commits intodevelopfrom
tolik/format-schema

Conversation

@tolikzinovyev
Copy link
Contributor

Summary

Makes formatting consistent.

@tolikzinovyev tolikzinovyev added Unplanned tech debt Things that need re-work for simplification / sanitization to reduce implementation overhead Team Carbon-11 labels Dec 1, 2021
@tolikzinovyev tolikzinovyev requested a review from winder December 1, 2021 18:22
@tolikzinovyev tolikzinovyev self-assigned this Dec 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #803 (a32030f) into develop (f372206) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #803   +/-   ##
========================================
  Coverage    58.83%   58.83%           
========================================
  Files           29       29           
  Lines         4059     4059           
========================================
  Hits          2388     2388           
  Misses        1374     1374           
  Partials       297      297           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f372206...a32030f. Read the comment docs.

Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something weird is going on, why are there mixed tabs and spaces?

@tolikzinovyev
Copy link
Contributor Author

Where? I see only spaces in .sql and only tabs in .go.

@winder
Copy link
Contributor

winder commented Dec 2, 2021

I should have been more specific, the mixed indentation is outside of the diff:

image

@tolikzinovyev
Copy link
Contributor Author

I think I didn't run go generate after my last edit. It's fixed now.

@tolikzinovyev tolikzinovyev merged commit be3375e into develop Dec 2, 2021
@tolikzinovyev tolikzinovyev deleted the tolik/format-schema branch December 2, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Carbon-11 tech debt Things that need re-work for simplification / sanitization to reduce implementation overhead Unplanned

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants