Include import-validator as a hidden algorand-indexer subcommand.#871
Include import-validator as a hidden algorand-indexer subcommand.#871
Conversation
|
What's the rationale? |
@tolikzinovyev Bundling in the most useful utilities should make it easier to perform release testing and ensure the utilities match the algorand-indexer version. There is also some automation I want to add, which will be simpler if I don't have to rebuild the utilities when a new release is detected. I'm planning to include |
|
could you give one specific example where this is useful? |
I would like to setup the There is some release automation with similar issues, they become more straight-forward when the utilities are bundled together:
|
tolikzinovyev
left a comment
There was a problem hiding this comment.
The code looks good, but imo it seems like too much automation. You could have a script that takes a git hash as input and does everything else.
Summary
Add a
./algorand-indexer import-validatorsubcommand which behaves the same as the currentimport-validatorutility.Test Plan
Manual testing:
docker run -it --rm --name some-postgres -p 5555:5432 -e POSTGRES_PASSWORD=algorand -e POSTGRES_USER=algorand -e POSTGRES_DB=algorand postgres./import-validator --postgres "user=algorand password=algorand host=localhost dbname=algorand port=5555 sslmode=disable" --algod-net https://<URL> --algod-token <token> --algod-ledger ledger./algorand-indexer import-validator --postgres "user=algorand password=algorand host=localhost dbname=algorand port=5555 sslmode=disable" --algod-net https://<URL> --algod-token <token> --algod-ledger ../import-validator/ledger