Feat: Qwen2.5 VIT hipblaslt swizzle #685
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ROCm/hipBLASLt “swizzle” support for Qwen2.5-VL vision attention weights and swaps vision attention Linear layers to ROCm-optimized implementations after weight load.
Changes:
- Override multimodal weight loading to optionally swizzle attention weights based on an env flag.
- Add
_replace_with_rocm_linear()to vision attention modules and invoke it post-load on ROCm. - Introduce ROCm platform check (
is_hip) to gate the ROCm-specific path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| rtp_llm/models/qwen2_5_vl/qwen2_5_vl.py | Adds swizzle-aware multimodal weight loading and post-load replacement of attention Linear layers. |
| rtp_llm/models/qwen2_5_vl/modeling_qwen2_5_vl.py | Adds ROCm Linear replacement helpers to vision attention classes and ROCm gating via is_hip(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
internal source has been updated, please review the changes! |
zhaoan12-prc
force-pushed
the
zhaoan/vit_hipblaslt_swizzle
branch
from
5a13105 to
2f7a4e3
Compare
Collaborator
|
internal source has been updated, please review the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: Qwen2.5 VIT hipblaslt swizzle