[WIP] Merge modules updating from nginx 1.15.1#1105
Merged
wangfakang merged 42 commits intoalibaba:masterfrom Dec 20, 2018
Merged
[WIP] Merge modules updating from nginx 1.15.1#1105wangfakang merged 42 commits intoalibaba:masterfrom
wangfakang merged 42 commits intoalibaba:masterfrom
Conversation
There is case failure in userid.t: not ok 23 - redefine expire This is that Tengine refactors 404 error page, not a bug.
fixed this case for Tengine via setting `worker_processes 1;`
chobits
commented
Oct 9, 2018
|
|
||
| $s = http_get('/req', start => 1); | ||
| SKIP: { | ||
| skip 'Tengine does not count when the variable arg_r is null '; |
Member
Author
There was a problem hiding this comment.
skip failed test case for current Tengine.
When Tengine merged nginx-1.15.x completely, this case will pass.
chobits
commented
Oct 9, 2018
| %%TEST_GLOBALS%% | ||
|
|
||
| daemon off; | ||
| worker_processes 1; # NOTE: The default value of Tengine worker_processes directive is `worker_processes auto;`. |
Member
Author
There was a problem hiding this comment.
fixed this case for Tengine.
Collaborator
|
ack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
worker_processes 1;