[core] node: Update status when reevaluating a node's locked status#2920
Draft
[core] node: Update status when reevaluating a node's locked status#2920
Conversation
If a node has been successfully computed and its locked status is reevaluated, the node's status should be updated from the cache to ensure all the information are correctly reflected.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2920 +/- ##
========================================
Coverage 80.61% 80.61%
========================================
Files 55 55
Lines 7692 7693 +1
========================================
+ Hits 6201 6202 +1
Misses 1491 1491 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fabiencastan
requested changes
Oct 16, 2025
Member
fabiencastan
left a comment
fabiencastan
left a comment
There was a problem hiding this comment.
Locked is a consequence of the status update, not the source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue that occurs for nodes with dynamic output attributes that are computed externally: once the node's status was updated to "SUCCESS", the values of the dynamic output attributes were not refreshed, and they remained as they were prior to the computation (although they had correctly been written in the node's
valuesfile). This never occurred for locally-computed nodes. To work around this issue, the user needed to use the "Refresh Nodes Status" option.With this PR, if a node has been successfully computed and its locked status is re-evaluated, then its status is updated from the cache, ensuring all the information are correctly reflected in the Graph Editor without needing an action from the user.