Fix search for LLVM to prefer LLVM_ROOT if specified#7
Merged
Conversation
If the system has LLVM 13, but we want to build with LLVM 12, this way we can set LLVM_ROOT or LLVM_DIR to force v12 to be used.
ba28e9d to
902cd00
Compare
Author
|
(Force-pushed to fix formatting only.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the system has LLVM 13, but we want to build with LLVM 12, this way we can set
LLVM_ROOTorLLVM_DIRto force v12 to be used.As far as I can tell, this works for me. In an slc8-gpu container, libgandiva is not linked against the system LLVM 13: