refactor: dead-code - remove unused exports across common/ and service packages #8
Description
Summary
Remove confirmed dead code across the common/ package and service packages. This includes unused functions, type aliases, constants, struct fields, and test helpers that were leftover from pre-DI refactoring or never adopted.
Location
common/ package:
internal/common/deps.go:33—GetAuthenticatedClient()(superseded by DI pattern)internal/common/types.go:12—AuthManagerInterface(never used, concrete type used instead)internal/common/args.go:14—ParseInt64Arg()(never called)
gmail:
internal/gmail/gmail_tools.go:15—GmailLabelListFieldsconstant (never used)internal/gmail/gmail_tools.go:17—GmailMessageListFieldsconstant (never used)
calendar:
internal/calendar/calendar_tools.go:46—var _ = calendar.Event{}(dummy import suppression; remove unused import)
tasks:
internal/tasks/tasks_service.go:47-48—ShowAssigned,ShowOnlyAssignedMefields onListTasksOptions(never read or set)internal/tasks/tasks_test_helpers.go:171-176—createTestTaskWithParent()(never called from tests)
14 unused type aliases across all 7 *_handlers.go files:
XxxServiceFactoryandMockXxxServiceFactoryon lines 15-16 of each handlers file (gmail, calendar, contacts, docs, drive, sheets, tasks)
Category
Type: Dead Code
Severity: High
Evidence
Verified by grep across entire codebase — none of these symbols are referenced outside their declaration.
Suggested Refactoring
- Delete each unused symbol
- Remove any imports that become unused after deletion
- Run
go build ./...andgo test ./...to verify
Effort Estimate
- Size: Small (< 1 hour)
- Risk: Low (dead code removal, no behavior change)
- Tests Required: No new tests (existing tests must pass)
Acceptance Criteria
- All listed dead code removed
- No unused imports remain
-
go build ./...passes -
go test ./...passes - No regression in functionality