v2.2 frontend: BuilderProxy.outputFile returns `"<property object at 0x000002D22AF75940>"`

[peace-maker]

While compiling SourceMod on windows I noticed funny defines on the commandline: /DBINARY_NAME="<property object at 0x000002D22AF75940>"

This happens for e.g. the sourcemod.2.css or ´game.cstrike.ext.2.css or sdkhooks.ext.2.css target, all of which use the BuilderProxy class.

ambuild/ambuild2/frontend/v2_2/cpp/builders.py

Lines 42 to 44 in 551dd3f

	@property
	def outputFile(self):
	return self.constructor_.outputFile

Replacing the return with computeLinkerOutputFile doesn't work since the .type property doesn't exist. I don't see where that is supposed to come from and think it got lost during some refactorization?

    @property
    def outputFile(self):
        return self.constructor_.computeLinkerOutputFile(self.name_, self.constructor_.type)

The other implementation in BinaryBuilder uses self.type without ever defining it.

ambuild/ambuild2/frontend/v2_2/cpp/builders.py

Lines 405 to 419 in 551dd3f

	class BinaryBuilder(BinaryBuilderBase):
	def __init__(self, compiler, name):
	super(BinaryBuilder, self).__init__(compiler, name)
	self.custom = []
	self.include_hotlist = []
	self.used_cxx_ = False
	self.linker_ = None
	self.modules_ = []
	self.has_code_ = False
	self.pch_nodes_ = []
	self.has_shared_pdb_ = False
	@property
	def outputFile(self):
	return self.computeLinkerOutputFile(self.name_, self.type)

[22772] C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.37.32822\bin\HostX64\x86\cl.exe /MTd /W3 /Ox /Zo /Od /RTC1 /Oy- /Z7 /D_CRT_SECURE_NO_DEPRECATE /D_CRT_SECURE_NO_WARNINGS /D_CRT_NONSTDC_NO_DEPRECATE /D_ITERATOR_DEBUG_LEVEL=0 /DNDEBUG /DDEBUG /D_DEBUG /DWIN32 /D_WINDOWS /DSOURCEMOD_BUILD /DSM_USE_VERSIONLIB /DSM_GENERATED_BUILD /DHAVE_STRING_H /DSE_BLOODYGOODTIME=4 /DSE_BLADE=19 /DSE_BMS=11 /DSE_CONTAGION=15 /DSE_CS2=25 /DSE_CSGO=23 /DSE_CSS=6 /DSE_DARKMESSIAH=2 /DSE_DODS=8 /DSE_DOI=21 /DSE_DOTA=24 /DSE_EPISODEONE=1 /DSE_EYE=5 /DSE_HL2DM=7 /DSE_INSURGENCY=20 /DSE_LEFT4DEAD=13 /DSE_LEFT4DEAD2=16 /DSE_MCV=22 /DSE_MOCK=26 /DSE_NUCLEARDAWN=14 /DSE_ORANGEBOX=3 /DSE_PORTAL2=18 /DSE_PVKII=10 /DSE_SDK2013=9 /DSE_ALIENSWARM=17 /DSE_TF2=12 /DSOURCE_ENGINE=6 /DCOMPILER_MSVC /DCOMPILER_MSVC32 /I ..\..\..\..\..\public /I ..\..\..\..\includes /I ..\..\..\..\..\versionlib /D_CRT_SECURE_NO_DEPRECATE /D_CRT_SECURE_NO_WARNINGS /D_CRT_NONSTDC_NO_DEPRECATE /D_ITERATOR_DEBUG_LEVEL=0 /DNDEBUG /DDEBUG /D_DEBUG /DWIN32 /D_WINDOWS /DSOURCEMOD_BUILD /DSM_USE_VERSIONLIB /DSM_GENERATED_BUILD /DHAVE_STRING_H /DSE_BLOODYGOODTIME=4 /DSE_BLADE=19 /DSE_BMS=11 /DSE_CONTAGION=15 /DSE_CS2=25 /DSE_CSGO=23 /DSE_CSS=6 /DSE_DARKMESSIAH=2 /DSE_DODS=8 /DSE_DOI=21 /DSE_DOTA=24 /DSE_EPISODEONE=1 /DSE_EYE=5 /DSE_HL2DM=7 /DSE_INSURGENCY=20 /DSE_LEFT4DEAD=13 /DSE_LEFT4DEAD2=16 /DSE_MCV=22 /DSE_MOCK=26 /DSE_NUCLEARDAWN=14 /DSE_ORANGEBOX=3 /DSE_PORTAL2=18 /DSE_PVKII=10 /DSE_SDK2013=9 /DSE_ALIENSWARM=17 /DSE_TF2=12 /DSOURCE_ENGINE=6 /DCOMPILER_MSVC /DCOMPILER_MSVC32 /DBINARY_NAME="<property object at 0x000002D22AF75940>" /DRC_COMPILE /DSM_GENERATED_BUILD /I ..\..\..\..\..\public /I ..\..\..\..\includes /I ..\..\..\..\..\versionlib /I ..\..\..\..\..\..\mmsource-1.12\core /I ..\..\..\..\..\..\mmsource-1.12\core\sourcehook /I ..\..\..\..\..\..\hl2sdk-css\public /I ..\..\..\..\..\..\hl2sdk-css\public\engine /I ..\..\..\..\..\..\hl2sdk-css\public\mathlib /I ..\..\..\..\..\..\hl2sdk-css\public\vstdlib /I ..\..\..\..\..\..\hl2sdk-css\public\tier0 /I ..\..\..\..\..\..\hl2sdk-css\public\tier1 /I ..\..\..\..\..\..\hl2sdk-css\public\toolframework /I ..\..\..\..\..\..\hl2sdk-css\public\game\server /I ..\..\..\..\..\..\hl2sdk-css\game\shared /I ..\..\..\..\..\..\hl2sdk-css\common /I ..\..\..\..\..\extensions\cstrike /I ..\..\..\..\..\extensions\cstrike\sdk /I ..\..\..\..\..\public\extensions /I ..\..\..\..\..\sourcepawn\include /I ..\..\..\..\..\public\amtl\amtl /I ..\..\..\..\..\public\amtl /I ..\..\..\..\..\public\safetyhook\include /showIncludes /nologo /P /c C:\Users\Jannik\Documents\GitHub\sourcemod\extensions\cstrike\version.rc /Fiversion.i && C:\Program Files (x86)\Windows Kits\10\bin\10.0.22621.0\\x64\rc.exe /nologo /d _CRT_SECURE_NO_DEPRECATE /d _CRT_SECURE_NO_WARNINGS /d _CRT_NONSTDC_NO_DEPRECATE /d _ITERATOR_DEBUG_LEVEL=0 /d NDEBUG /d DEBUG /d _DEBUG /d WIN32 /d _WINDOWS /d SOURCEMOD_BUILD /d SM_USE_VERSIONLIB /d SM_GENERATED_BUILD /d HAVE_STRING_H /d SE_BLOODYGOODTIME=4 /d SE_BLADE=19 /d SE_BMS=11 /d SE_CONTAGION=15 /d SE_CS2=25 /d SE_CSGO=23 /d SE_CSS=6 /d SE_DARKMESSIAH=2 /d SE_DODS=8 /d SE_DOI=21 /d SE_DOTA=24 /d SE_EPISODEONE=1 /d SE_EYE=5 /d SE_HL2DM=7 /d SE_INSURGENCY=20 /d SE_LEFT4DEAD=13 /d SE_LEFT4DEAD2=16 /d SE_MCV=22 /d SE_MOCK=26 /d SE_NUCLEARDAWN=14 /d SE_ORANGEBOX=3 /d SE_PORTAL2=18 /d SE_PVKII=10 /d SE_SDK2013=9 /d SE_ALIENSWARM=17 /d SE_TF2=12 /d SOURCE_ENGINE=6 /d COMPILER_MSVC /d COMPILER_MSVC32 /d BINARY_NAME="<property object at 0x000002D22AF75940>" /d RC_COMPILE /d SM_GENERATED_BUILD /i ..\..\..\..\..\public /i ..\..\..\..\includes /i ..\..\..\..\..\versionlib /i ..\..\..\..\..\..\mmsource-1.12\core /i ..\..\..\..\..\..\mmsource-1.12\core\sourcehook /i ..\..\..\..\..\..\hl2sdk-css\public /i ..\..\..\..\..\..\hl2sdk-css\public\engine /i ..\..\..\..\..\..\hl2sdk-css\public\mathlib /i ..\..\..\..\..\..\hl2sdk-css\public\vstdlib /i ..\..\..\..\..\..\hl2sdk-css\public\tier0 /i ..\..\..\..\..\..\hl2sdk-css\public\tier1 /i ..\..\..\..\..\..\hl2sdk-css\public\toolframework /i ..\..\..\..\..\..\hl2sdk-css\public\game\server /i ..\..\..\..\..\..\hl2sdk-css\game\shared /i ..\..\..\..\..\..\hl2sdk-css\common /i ..\..\..\..\..\extensions\cstrike /i ..\..\..\..\..\extensions\cstrike\sdk /i ..\..\..\..\..\public\extensions /i ..\..\..\..\..\sourcepawn\include /i ..\..\..\..\..\public\amtl\amtl /i ..\..\..\..\..\public\amtl /i ..\..\..\..\..\public\safetyhook\include /foversion.res C:\Users\Jannik\Documents\GitHub\sourcemod\extensions\cstrike\version.rc