Skip to content

Fix getFullName method in CestProvider.php (via #97) #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eroshenkoam merged 3 commits into from
May 11, 2022
Merged

Fix getFullName method in CestProvider.php (via #97) #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed4317a
fix-full-name-getter-for-cest
nixdrey-wb May 11, 2022
af1ab4f
Merge branch 'main' of github.com:nixdrey/allure-codeception into fix…
nixdrey-wb May 11, 2022
9715286
Fix getFullName method for CestProvider
nixdrey-wb May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Internal/CestProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,12 @@ public function getDescriptionHtml(): ?string
return null;
}

/**
* @psalm-suppress MixedOperand
* @psalm-suppress MixedArgument
*/
public function getFullName(): ?string
{
return null;
return get_class($this->test->getTestClass()) . "::" . $this->test->getTestMethod();
}
}
20 changes: 20 additions & 0 deletions test/codeception/unit/CestProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?php

declare(strict_types=1);

namespace Qameta\Allure\Codeception\Test\Unit;

use Codeception\Test\Cest;
use Codeception\Test\Unit;
use Qameta\Allure\Codeception\Internal\CestProvider;

class CestProviderTest extends Unit
{
public function testFullName(): void
{
$cest = new Cest($this, 'a', 'b');
$cestProvider = new CestProvider($cest);

$this->assertSame(__CLASS__ . '::' . 'a', $cestProvider->getFullName());
}
}