Add option to have required reference types and use C# nullability annotations#678
Draft
mrinal-thomas wants to merge 2 commits intoaloneguid:masterfrom
Draft
Add option to have required reference types and use C# nullability annotations#678mrinal-thomas wants to merge 2 commits intoaloneguid:masterfrom
mrinal-thomas wants to merge 2 commits intoaloneguid:masterfrom
Conversation
Includes minor refactor to avoid passing down forWriting and useNullableAnnotation through multiple method calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds feature #618, using the C#
NullabilityInfoclass to check for nullability annotations. I also made a small coding style refactor to storeuseWritingand the newuseNullableAnnotationsoption in an instance variable rather than passing through the call stack everywhere.Note: potential risky area is behavior around the
[ParquetRequired]attribute. You may want to double check I preserved this behavior correctly. Another potential risky area is I added nullability check toField.Equals. I couldn't find any existing behavior that would be affected by this, but might be worth double checking as well.