Avoid EndOfStreamException with empty pages#95
Merged
aloneguid merged 2 commits intoaloneguid:masterfrom Feb 28, 2021
Merged
Conversation
aloneguid
approved these changes
Feb 28, 2021
Contributor
Author
|
@aloneguid My first OSS contribution ✨😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #88
Description
Allows for there to be no RLE or Bitpacked values on a data page. On occasion I find Spark creates these 'empty' pages. They have a valid header, and accurate byte counts, but no values.
I'm not clear whether these are allowed by the spec... but they are 'de facto' correct: Spark writes them; Python/pandas can read them ok.
There is no test in this PR. This Gist contains the test I use locally, unfortunately I cannot share the file that goes with it.
⚠️ Help needed. @peteriehl can you help to provide a repro file?