Closed
Conversation
Collaborator
|
I wish we could reconsider #236, to be fair (without the object support if Caleb is not sure). I think it's annoying that x-on:style overrides any values in pre existing style attributes. |
Contributor
Author
|
I can revive it I think the biggest issue was added bulk from that but if we just do string merging it should be ok. |
Collaborator
|
Ok, I think Alpine should force x-show to override any :show bindings. Is there a simple way to accomplish this without digging into the object syntax support (which I think we will likely end up adding after all)? |
Contributor
Author
|
Well the only bit from that PR that we would need is the "style rule merging", or we can just order the operations so that |
Contributor
Author
|
Closing since we're going to order the things |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #434