Skip to content

Allow coroutines in service methods#27

Merged
acrisci merged 3 commits into
altdesktop:masterfrom
SilvairGit:async_service_methods
Dec 29, 2019
Merged

Allow coroutines in service methods#27
acrisci merged 3 commits into
altdesktop:masterfrom
SilvairGit:async_service_methods

Conversation

@michallowasrzechonek-silvair
Copy link
Copy Markdown
Contributor

fixes #24

Comment thread dbus_next/message_bus.py Outdated
@acrisci
Copy link
Copy Markdown
Member

acrisci commented Dec 28, 2019

Run make format to run yapf on the source files.

@michallowasrzechonek-silvair
Copy link
Copy Markdown
Contributor Author

If this approach looks good, I think it should also work for asynchronous properties, by replacing getattr and setattr with similar callback-based setters, cf.

@acrisci
Copy link
Copy Markdown
Member

acrisci commented Dec 28, 2019

Yeah this approach seems good. That should work for properties, as long as it doesn't break the existing user interface because I like how that works right now.

@michallowasrzechonek-silvair
Copy link
Copy Markdown
Contributor Author

michallowasrzechonek-silvair commented Dec 28, 2019

Alright, I'll try to come up with something that doesn't change the API. That would be a separate PR, though.

@michallowasrzechonek-silvair michallowasrzechonek-silvair changed the title [RFC] Allow coroutines in service methods Allow coroutines in service methods Dec 28, 2019
@acrisci
Copy link
Copy Markdown
Member

acrisci commented Dec 29, 2019

Looks good thanks 👍

@acrisci acrisci merged commit 594fd5c into altdesktop:master Dec 29, 2019
@michallowasrzechonek-silvair michallowasrzechonek-silvair deleted the async_service_methods branch July 14, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No non-blocking service methods

2 participants