Allow coroutines in service methods#27
Merged
Merged
Conversation
4291fa4 to
313f2e9
Compare
acrisci
reviewed
Dec 28, 2019
Member
|
Run |
313f2e9 to
0b228d1
Compare
Contributor
Author
|
If this approach looks good, I think it should also work for asynchronous properties, by replacing |
Member
|
Yeah this approach seems good. That should work for properties, as long as it doesn't break the existing user interface because I like how that works right now. |
Contributor
Author
|
Alright, I'll try to come up with something that doesn't change the API. That would be a separate PR, though. |
Member
|
Looks good thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #24