Bug fix in property validation error message#81
Merged
acrisci merged 1 commit intoJan 29, 2021
Conversation
#### Issue * `member` is undefined here and triggers an AttributeError, causing user to miss the actual error message. #### Fix * Replace `member` with `prop`. Tested by creating a RW property without a setter and got the correct error message: ``` ValueError: property "MyProp" is writable but does not have a setter ```
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
memberis undefined here and triggers an AttributeError, causinguser to miss the actual error message.
Fix
memberwithprop. Tested by creating a RW propertywithout a setter and got the correct error message: