add fail and wait actions#2
Merged
Merged
Conversation
Collaborator
Author
|
@ambarc could use review here |
ambarc
reviewed
Aug 1, 2025
|
|
||
| @self.registry.action('Wait for specified duration', param_model=WaitAction) | ||
| async def wait(params: WaitAction, browser: BrowserContext): | ||
| import asyncio |
Owner
There was a problem hiding this comment.
i'd import this up top; worth noting that misuse of asyncio is probably why we're slowing down with multiple agents at the moment. ask - move import to top of file, keep this line saved in mind in case we see odd hangs with wait.
Owner
There was a problem hiding this comment.
helps to test wait a bunch before merging because of its sleep cmd.
Collaborator
Author
There was a problem hiding this comment.
performed test on wait, confirming the agent can wait a specified amount of time and keep its own count
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding actions for agent to
fail if not seeing a viable path to execute instructions
wait if it suspects a page needs more time to load before actions are available