Skip to content

New Skill: rocm-doctor - #87

Open
volen-silo wants to merge 5 commits into
mainfrom
rocm-doctor-publish
Open

New Skill: rocm-doctor#87
volen-silo wants to merge 5 commits into
mainfrom
rocm-doctor-publish

Conversation

@volen-silo

Copy link
Copy Markdown
Collaborator

What

Publishes the rocm-doctor skill: diagnoses ROCm / HIP / PyTorch / llama.cpp failures on AMD GPUs (Linux + Windows) against the closed failure-mode catalog now shipped natively in the rocm CLI (ROCm/rocm-cli#39: rocm examine / rocm diagnose / rocm fix). The skill is a thin driver over those commands — it fixes with consent or routes upstream, and never re-implements the probe/catalog/fixes.

Changes

  • New skill skills/rocm-doctor/ (SKILL.md, reference.md, skill-card.md), verified against the shipped rocm-core implementation (exit codes, JSON fields, the 15-mode catalog, the 4 auto-applicable fixes).
  • Phase 0 install step — the skill installs the rocm CLI (with user consent) when missing, so it's self-sufficient instead of dead-ending.
  • Register in .claude-plugin/marketplace.json; regenerate the derived Cursor/Codex/agents manifests.
  • README — mark rocm-doctor as in-repo (was _planned_) and genericize the "what is a skill?" example tree.
  • Cleanup — remove the superseded staging/rocm-doctor/ copy (old Python-scripts version) and the now-dead skillspector-allow.yml suppressions that pointed at those deleted scripts.

Notes

  • In-repo (Path A) skill — no sources.yml / federation entry needed.
  • check.sh passes: 0 errors across 7 skills, manifests in sync.

@volen-silo
volen-silo requested a review from danielholanda July 10, 2026 12:45
@danielholanda

Copy link
Copy Markdown
Collaborator

@volen-silo Can you please also add a quick walkthrough to this skill? This will make reviewing this much easier.
https://github.com/amd/skills/tree/main/walkthroughs

A good/simple reference is https://github.com/amd/skills/blob/main/walkthroughs/local-ai-use.md

Add the rocm-doctor skill to the catalog: diagnoses ROCm/HIP/PyTorch/
llama.cpp failures on AMD GPUs against the closed catalog now shipped in
the rocm CLI (rocm examine / diagnose / fix), fixing with consent or
routing upstream. A Phase 0 step installs the rocm CLI (with consent) when
it's missing so the skill is self-sufficient. Register it in the
marketplace, regenerate the derived manifests, mark it in-repo in the
README, drop the superseded staging copy, and remove the now-dead
skillspector suppressions for the deleted staging scripts.

Signed-off-by: Eugene Volen <Eugene.Volen@amd.com>
@volen-silo
volen-silo force-pushed the rocm-doctor-publish branch from d338463 to fdd2fa6 Compare July 16, 2026 10:15
@danielholanda

Copy link
Copy Markdown
Collaborator

@sreeram-11 to provide an initial review

@sreeram-11

sreeram-11 commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

@volen-silo, thank you for adding the rocm-doctor skill!

Tried it out on my Strix Halo laptop (gfx1151, Windows). Overall it works as expected and I'd say it's good to ship. I tested on a clean Windows machine, so the Linux-only fixes and the ones needing real host conditions couldn't be exercised. What I could hit worked correctly.

  • What I checked:

    • Real error strings (e.g. hipErrorNoBinaryForGpu, missing vcruntime140_1.dll) matched the correct fix with sensible confidence scores.
    • Junk/unrelated input correctly returned no match and routed upstream, no hallucinated fixes.
    • Confidence tiers work: low-confidence host conditions stay below the match threshold and don't get surfaced as "the answer."
  • One thing worth noting: When an app is named only in the error text (Lemonade, Ollama), the CLI defaults to routing to rocm-core. The skill's instructions tell the agent to redirect to the right tracker instead, so that routing depends on the skill layer doing its job, not the CLI. Worked correctly, just good to know that's where the logic lives.

  • Takeaway: Working as expected.

Adds the required evals/evals.py behavioral suite (trigger and non-trigger
sets, deterministic logs_contains checks plus LLM-judged should/should_not),
and fills the two SKILL.md gaps: an explicit Prerequisites section and a
proper markdown link to reference.md.

Signed-off-by: Eugene Volen <Eugene.Volen@amd.com>
@volen-silo
volen-silo force-pushed the rocm-doctor-publish branch from 4d9af70 to 941a326 Compare July 31, 2026 14:31
@sree-ram-11

Copy link
Copy Markdown

@volen-silo, thank you for adding the rocm-doctor skill!

Tried it out on my Strix Halo laptop (gfx1151, Windows). Overall it works as expected and I'd say it's good to ship. I tested on a clean Windows machine, so the Linux-only fixes and the ones needing real host conditions couldn't be exercised. What I could hit worked correctly.

  • What I checked:

    • Real error strings (e.g. hipErrorNoBinaryForGpu, missing vcruntime140_1.dll) matched the correct fix with sensible confidence scores.
    • Junk/unrelated input correctly returned no match and routed upstream, no hallucinated fixes.
    • Confidence tiers work: low-confidence host conditions stay below the match threshold and don't get surfaced as "the answer."
  • One thing worth noting: When an app is named only in the error text (Lemonade, Ollama), the CLI defaults to routing to rocm-core. The skill's instructions tell the agent to redirect to the right tracker instead, so that routing depends on the skill layer doing its job, not the CLI. Worked correctly, just good to know that's where the logic lives.

  • Takeaway: Working as expected.

@danielholanda danielholanda changed the title Publish rocm-doctor skill New Skill: rocm-doctor Aug 5, 2026
"skills": [
"./skills/local-ai-use",
"./skills/local-ai-app-integration",
"./skills/rocm-doctor",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all changes to marketplace files. We will add those later to those "showcase" catalogs subject to marketing approval.

@danielholanda danielholanda left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the behavioral tests here, but it looks like some of those are a bit flaky. Can you take a look at the failing tests?

https://github.com/amd/skills/actions/runs/31060854272/job/92488416742?pr=87

@danielholanda

Copy link
Copy Markdown
Collaborator

Adding @sdevinenamd @meghsat here as a reviewer

@sdevinenamd

Copy link
Copy Markdown
Collaborator

Thank you for creating this skill @volen-silo! It looks solid!

I tested this skill on a Windows machine without ROCm installed. It successfully checked for the ROCm CLI, installed it, and guided me through HIPInfo installation errors as well as ROCm binary installation issues.

I also tried asking about Lemonade-related ROCm errors, and instead of blindly attempting to fix them, it correctly pointed me to the Lemonade documentation and suggested a description for the issue. Additionally, I tested several competitor-related and WSL prompts, and all of them worked as expected.

Suggestions/ questions:

  1. I tried asking an unrelated question: "Write Python code for the Fibonacci series and run it on my local Python setup." The skill provided a response and produced the result. I'm not sure whether this is expected behavior or if we should explicitly prevent the skill from answering unrelated questions.
  2. Consider including an evaluation script for WSL2. It is currently only mentioned in the skill.md, and adding an eval script could help reinforce that WSL2-related topics are out of scope.
  3. I noticed that the skill.md currently pulls the nightly build. I assume this will be changed to use the stable release later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants