New Skill: rocm-doctor - #87
Conversation
|
@volen-silo Can you please also add a quick walkthrough to this skill? This will make reviewing this much easier. A good/simple reference is https://github.com/amd/skills/blob/main/walkthroughs/local-ai-use.md |
Add the rocm-doctor skill to the catalog: diagnoses ROCm/HIP/PyTorch/ llama.cpp failures on AMD GPUs against the closed catalog now shipped in the rocm CLI (rocm examine / diagnose / fix), fixing with consent or routing upstream. A Phase 0 step installs the rocm CLI (with consent) when it's missing so the skill is self-sufficient. Register it in the marketplace, regenerate the derived manifests, mark it in-repo in the README, drop the superseded staging copy, and remove the now-dead skillspector suppressions for the deleted staging scripts. Signed-off-by: Eugene Volen <Eugene.Volen@amd.com>
d338463 to
fdd2fa6
Compare
|
@sreeram-11 to provide an initial review |
|
@volen-silo, thank you for adding the Tried it out on my Strix Halo laptop (gfx1151, Windows). Overall it works as expected and I'd say it's good to ship. I tested on a clean Windows machine, so the Linux-only fixes and the ones needing real host conditions couldn't be exercised. What I could hit worked correctly.
|
Adds the required evals/evals.py behavioral suite (trigger and non-trigger sets, deterministic logs_contains checks plus LLM-judged should/should_not), and fills the two SKILL.md gaps: an explicit Prerequisites section and a proper markdown link to reference.md. Signed-off-by: Eugene Volen <Eugene.Volen@amd.com>
4d9af70 to
941a326
Compare
|
@volen-silo, thank you for adding the Tried it out on my Strix Halo laptop (gfx1151, Windows). Overall it works as expected and I'd say it's good to ship. I tested on a clean Windows machine, so the Linux-only fixes and the ones needing real host conditions couldn't be exercised. What I could hit worked correctly.
|
| "skills": [ | ||
| "./skills/local-ai-use", | ||
| "./skills/local-ai-app-integration", | ||
| "./skills/rocm-doctor", |
There was a problem hiding this comment.
Please remove all changes to marketplace files. We will add those later to those "showcase" catalogs subject to marketing approval.
danielholanda
left a comment
There was a problem hiding this comment.
I really like the behavioral tests here, but it looks like some of those are a bit flaky. Can you take a look at the failing tests?
https://github.com/amd/skills/actions/runs/31060854272/job/92488416742?pr=87
|
Adding @sdevinenamd @meghsat here as a reviewer |
|
Thank you for creating this skill @volen-silo! It looks solid! I tested this skill on a Windows machine without ROCm installed. It successfully checked for the ROCm CLI, installed it, and guided me through HIPInfo installation errors as well as ROCm binary installation issues. I also tried asking about Lemonade-related ROCm errors, and instead of blindly attempting to fix them, it correctly pointed me to the Lemonade documentation and suggested a description for the issue. Additionally, I tested several competitor-related and WSL prompts, and all of them worked as expected. Suggestions/ questions:
|
What
Publishes the rocm-doctor skill: diagnoses ROCm / HIP / PyTorch / llama.cpp failures on AMD GPUs (Linux + Windows) against the closed failure-mode catalog now shipped natively in the
rocmCLI (ROCm/rocm-cli#39:rocm examine/rocm diagnose/rocm fix). The skill is a thin driver over those commands — it fixes with consent or routes upstream, and never re-implements the probe/catalog/fixes.Changes
skills/rocm-doctor/(SKILL.md,reference.md,skill-card.md), verified against the shippedrocm-coreimplementation (exit codes, JSON fields, the 15-mode catalog, the 4 auto-applicable fixes).rocmCLI (with user consent) when missing, so it's self-sufficient instead of dead-ending..claude-plugin/marketplace.json; regenerate the derived Cursor/Codex/agents manifests.rocm-doctorasin-repo(was_planned_) and genericize the "what is a skill?" example tree.staging/rocm-doctor/copy (old Python-scripts version) and the now-deadskillspector-allow.ymlsuppressions that pointed at those deleted scripts.Notes
sources.yml/ federation entry needed.check.shpasses: 0 errors across 7 skills, manifests in sync.