Skip to content

Remove unnecessary new paragraph in style_pages.md#6838

Merged
powerivq merged 1 commit intoampproject:mainfrom
zhangsu:patch-1
Aug 14, 2024
Merged

Remove unnecessary new paragraph in style_pages.md#6838
powerivq merged 1 commit intoampproject:mainfrom
zhangsu:patch-1

Conversation

@zhangsu
Copy link
Member

@zhangsu zhangsu commented Aug 14, 2024

#6833 took a shortcut and applied the format filter on just part of the sentence. This resulted in the word "stylesheets" being put in a new paragraph after the word "external". Apparently, the filter mechanism always creates a new paragraph as opposed to coalescing all whitespace characters into a single space.

To fix this, we will have to duplicate some parts of the sentence, unfortunately.

/to @powerivq

ampproject#6833 took a shortcut and applied the format filter on just part of the sentence. This resulted in the word "stylesheets" being put in a new paragraph after the word "external". Apparently, the filter mechanism always creates a new paragraph as opposed to coalescing all whitespace characters into a single space.

To fix this, we will have to duplicate some parts of the sentence, unfortunately.
@powerivq powerivq merged commit c6a7b00 into ampproject:main Aug 14, 2024
@powerivq powerivq self-assigned this Aug 14, 2024
@zhangsu zhangsu deleted the patch-1 branch August 16, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants