Viewer messaging to select the next/previous document.#22684
Merged
gmajoulet merged 1 commit intoampproject:masterfrom Jun 4, 2019
Merged
Viewer messaging to select the next/previous document.#22684gmajoulet merged 1 commit intoampproject:masterfrom
gmajoulet merged 1 commit intoampproject:masterfrom
Conversation
newmuis
approved these changes
Jun 4, 2019
Contributor
newmuis
left a comment
newmuis
left a comment
There was a problem hiding this comment.
Mostly LGTM, just one thing that I think can be handled separately
| */ | ||
| onNoPreviousPage_() { | ||
| if (this.viewer_.hasCapability('swipe')) { | ||
| this.viewer_./*OK*/ sendMessage( |
Contributor
There was a problem hiding this comment.
Perhaps in a separate PR: Don't we need to handle a response (here and for no next page)? e.g. if the viewer tells us "there is no previous story" when the user has tapped to previous, we should still show the first page hint?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Story runtime decides to either show the bookend, or send a message to the viewer depending the the
#cap=swipeattribute.When displayed in the context of a viewer that has multiple documents, the story runtime doesn't show the bookend but asks the viewer to navigate to the next story.
This PR enables messaging to tap to a next or previous story and browse a feed of stories from a viewer.
SHOW_NO_PREVIOUS_PAGE_HELPevent intoNO_PREVIOUS_PAGENO_NEXT_PAGEevent. We should eventually move away from these events but it'd be a pretty large refactoring, and we were happy with their performance last time we checked.Fixes #22661, #15601