Merged
Conversation
Member
|
Story ad changes LGTM |
Contributor
|
Awesome!! |
Contributor
Author
|
Tests finished running in Travis, although Github doesn't seem to know about it yet. But it's ready for review @gmajoulet |
gmajoulet
reviewed
Jul 8, 2019
gmajoulet
reviewed
Jul 8, 2019
| this.storeService_.subscribe( | ||
| StateProperty.CURRENT_PAGE_ID, | ||
| pageId => { | ||
| if (pageId.length <= 0) { |
Contributor
There was a problem hiding this comment.
Is there any reason why you don't want to test !pageId?
This would throw an error for null or undefined, which isn't used today, but this test makes it look like pageId is an array
Contributor
Author
There was a problem hiding this comment.
Since CURRENT_PAGE_ID is initialized as '' in the store, I thought it might be safer. But both work fine. Changed it to !pageId.
gmajoulet
approved these changes
Jul 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19751
Closes #19768