📦 Update dependency sinon to v7.5.0

[renovate-bot]

This PR contains the following updates:

Package	Type	Update	Change
sinon (source)	devDependencies	minor	7.3.2 -> 7.5.0

---

Release Notes

sinonjs/sinon

v7.5.0

Compare Source

==================

• Add sinon.assert.calledOnceWithExactly
• Feature parity: support spying all methods on an object

v7.4.2

Compare Source

==================

• Restore sinon.createStubInstance() behaviour (#​2073)
• Fix Typo in migration 6 and updated migration docs for migration from… (#​2074)

v7.4.1

Compare Source

==================

• Update nise and lolex (minor versions)
• add callThroughWithNew method
• add browser field
• Create COMPATIBILITY.md (#​2051)
• Fix sinon.resetHistory() does not reset history (#​2022)

---

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Renovate Bot. View repository job log here.

[Enriqe]

/cc @ampproject/wg-infra it seems like the tests for this PR keep failing. Would you mind taking a look?

[rcebulko]

Travis failing, need to see if related.

[rsimha]

Travis failing, need to see if related.

Pretty sure it's related. I noticed that some of our tests use sandbox = sinon.sandbox in their beforeEach(), while others use sandbox = env.sandbox. I wonder if the new version of sinon is exposing this problem, and somehow resulting in btoa not being found (as the error logs suggest). Since this is happening only on Safari on Sauce Labs, it could have to do with polyfills / mocks.

If you don't spot an obvious solution, I'm happy to look at this next week.

[rcebulko]

@rsimha I don't, and I'm still figuring out how to navigate all the test outputs and figuring out what's failing where and why, so if/when you get to this I'd love to hear how you went about tracking it down

[rsimha]

Looks like this sinon upgrade is causing btoa to not be found on Safari (on Sauce Labs, if that matters). Logs here. The same tests run fine on Chrome, Firefox, etc.

Can't find variable: btoa

Paging folks from @ampproject/wg-runtime and @ampproject/wg-performance in case you know what's going on here.

[dreamofabear]

Not sure. Also didn't see anything suspicious looking in sinonjs/sinon@v7.3.2...v7.4.1, so it could be related a sinon dependency change.

Needs some sleuthing.

[rsimha]

Assigning this to some @ampproject/wg-runtime folks for help with sleuthing :)

[rsimha]

Still fixing test failures, which appears to be a larger undertaking than I initially anticipated.

Meanwhile, I'm moving d350b53 into a separate PR (#25455), since I believe it will address some flakiness we're seeing on master today without having to upgrade sinon.

[jridgewell]

Maybe we should take this file by file , instead of all at once?

[rsimha]

Maybe we should take this file by file , instead of all at once?

I couldn't come up with a way to upgrade sinon without fixing all tests. Let me know if you have a better idea. (I'll take another stab at fixing them this week.)

[rcebulko]

Is it possible to have two copies, replace all existing requires with require('legacy-sinon') or something equivalent, and migrate in chunks?

[rsimha]

Is it possible to have two copies, replace all existing requires with require('legacy-sinon') or something equivalent, and migrate in chunks?

That's more complicated than fixing the tests. Let's see what I find when I give this another go.

[rsimha]

Let's see what I find when I give this another go.

Figured out one thing I was doing incorrectly. For describes tests, I should've changed the global sinon.sandbox to env.sandbox and not window.sandbox. Updated PR coming up.

[rsimha]

After fixing hundreds of tests, I'd rather move this to a new PR so it can be properly reviewed, instead of piggybacking on a renovate package upgrade. I'm closing this in favor of #25587.