Story branching support for sidebar links.#24968
Merged
gmajoulet merged 2 commits intoampproject:masterfrom Oct 18, 2019
Merged
Story branching support for sidebar links.#24968gmajoulet merged 2 commits intoampproject:masterfrom
gmajoulet merged 2 commits intoampproject:masterfrom
Conversation
Contributor
Author
|
Friendly ping (for when the summit is over) :) |
Enriqe
approved these changes
Oct 14, 2019
| ); | ||
| // If open, closes the sidebar before navigating. | ||
| const promise = this.storeService_.get(StateProperty.SIDEBAR_STATE) | ||
| ? Services.historyForDoc(this.getAmpDoc()).goBack() |
Contributor
There was a problem hiding this comment.
curious: why do we do this instead of doing a dispatch(TOGGLE_SIDEBAR, false) to close the sidebar?
Contributor
Author
There was a problem hiding this comment.
Setting SIDEBAR_STATE to false would update the Story UI but would not run any code within amp-sidebar. We'd still have the sidebar history entry, its listeners, etc.
jeffjose
pushed a commit
to jeffjose/amphtml
that referenced
this pull request
Oct 19, 2019
* Squash Pet's commits. * Links in sidebar fixes.
joshuarrrr
pushed a commit
to Parsely/amphtml
that referenced
this pull request
Oct 22, 2019
* Squash Pet's commits. * Links in sidebar fixes.
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* Squash Pet's commits. * Links in sidebar fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating Pet's work from #20944
cc @bramanudom
#20083