Skip to content

📦 Update dependency prettier to v1.19.1#25524

Merged
jridgewell merged 2 commits intoampproject:masterfrom
renovate-bot:renovate/prettier-1.x
Nov 12, 2019
Merged

📦 Update dependency prettier to v1.19.1#25524
jridgewell merged 2 commits intoampproject:masterfrom
renovate-bot:renovate/prettier-1.x

Conversation

@renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Nov 9, 2019

This PR contains the following updates:

Package Type Update Change
prettier (source) devDependencies minor 1.18.2 -> 1.19.1

Release Notes

prettier/prettier

v1.19.1

Compare Source

diff

CLI
Fix --stdin regression in 1.19.0 (#​6894 by @​lydell)
// Prettier stable
$ echo "test" | prettier --stdin --parser babel
[error] regeneratorRuntime is not defined

// Prettier master
$ echo "test" | prettier --stdin --parser babel
test;
TypeScript
Fix formatting of union type as arrow function return type (#​6896 by @​thorn0)
// Input
export const getVehicleDescriptor = async (
  vehicleId: string,
): Promise<Collections.Parts.PrintedCircuitBoardAssembly['attributes'] | undefined> => {}

// Prettier stable
export const getVehicleDescriptor = async (
  vehicleId: string
): Promise<| Collections.Parts.PrintedCircuitBoardAssembly["attributes"]
| undefined> => {};

// Prettier master
export const getVehicleDescriptor = async (
  vehicleId: string
): Promise<
  Collections.Parts.PrintedCircuitBoardAssembly["attributes"] | undefined
> => {};

v1.19.0

Compare Source

diff

🔗 Release Notes


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate-bot renovate-bot force-pushed the renovate/prettier-1.x branch from f73b1fd to 7b3cb52 Compare November 9, 2019 12:48
@renovate-bot renovate-bot changed the title 📦 Update dependency prettier to v1.19.0 📦 Update dependency prettier to v1.19.1 Nov 9, 2019
@renovate-bot renovate-bot changed the title 📦 Update dependency prettier to v1.19.1 📦 Update dependency prettier to v1.19.1 Nov 9, 2019
@amp-owners-bot
Copy link

amp-owners-bot bot commented Nov 12, 2019

Hey @erwinmombay, these files were changed:

  • build-system/compile/single-pass.js

Hey @gmajoulet, these files were changed:

  • extensions/amp-story/1.0/test/test-amp-story.js

Hey @newmuis, these files were changed:

  • extensions/amp-story/1.0/test/test-amp-story.js

@danielrozenberg
Copy link
Member

@ampproject/wg-ads, @ampproject/wg-runtime for refactor approval

@danielrozenberg
Copy link
Member

@ampproject/wg-ui-and-a11y for refactor approval

Copy link

@dreamofabear dreamofabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. You can also sanity check by comparing compiled output before/after.

@forking-renovate
Copy link

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@jridgewell jridgewell merged commit ad497ca into ampproject:master Nov 12, 2019
@renovate-bot renovate-bot deleted the renovate/prettier-1.x branch November 12, 2019 20:24
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
* 📦 Update dependency prettier to v1.19.1

* `gulp lint --fix`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants